Skip to content

Commit

Permalink
feat!: remove the cluster_id variable
Browse files Browse the repository at this point in the history
When creating an SKS cluster, Exoscale used to provision a cluster domain value of `<CLUSTER_ID>.cluster.local`. This is the legacy value for SKS cluster domain.

They recently transitioned to provisioning SKS cluster with the default cluster domain value of `cluster.local`.

Consequently, we need to remove the adaptations on our modules that were there to support this bizarre, and now legacy, behavior.
  • Loading branch information
lentidas committed Jul 16, 2024
1 parent 3b1bd99 commit e4f19a1
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions sks/extra-variables.tf
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
variable "cluster_id" {
description = "ID of the SKS cluster."
type = string
}

variable "metrics_storage" {
description = "Exoscale SOS bucket configuration values for the bucket where the archived metrics will be stored."
type = object({
Expand Down
1 change: 0 additions & 1 deletion sks/locals.tf
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
locals {
helm_values = [{
thanos = {
clusterDomain = "${var.cluster_id}.cluster.local"
objstoreConfig = {
type = "S3"
config = {
Expand Down

0 comments on commit e4f19a1

Please sign in to comment.