fix: fix storage class creation when bootstrapping a cluster #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we set this, Longhorn creates a prototype StorageClass that Argo CD is then unable to update with the configurations desired, giving an error message `The StorageClass "longhorn-backup" is invalid: parameters: Forbidden: updates to parameters are forbidden.`.
Removing the attribute `defaultLonghornStaticStorageClass` removes that problem while maintaining the normal behavior of the module, as the StorageClass is set as default by the annotation `storageclass.kubernetes.io/is-default-class: {{ $.Values.backups.defaultStorageClass | quote }}`.
|
@hbollon I would like you take a look at this PR when you have the time, because your platform is the only using the module. Let me know if I overlooked something. |
hbollon
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
feat: move recurring jobs to their own resources
Instead of creating the recurring jobs from inside the StorageClass object, these are now created outside with their proper objects. They can still be selected to use by the StorageClass using the selectors that existed before.
fix: remove attribute causing issues when bootstrapping cluster
When we set this attribute, Longhorn creates a prototype StorageClass that Argo CD is then unable to update with the configurations desired, giving an error message
The StorageClass "longhorn-backup" is invalid: parameters: Forbidden: updates to parameters are forbidden..Removing the attribute
defaultLonghornStaticStorageClassremoves that problem while maintaining the normal behavior of the module, as the StorageClass is set as default by the annotationstorageclass.kubernetes.io/is-default-class: {{ $.Values.backups.defaultStorageClass | quote }}.Breaking change
Tests executed on which distribution(s)