Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade chart to v1.5.2 #21

Closed
wants to merge 2 commits into from
Closed

feat: upgrade chart to v1.5.2 #21

wants to merge 2 commits into from

Conversation

hbollon
Copy link
Member

@hbollon hbollon commented Jan 23, 2024

Description of the changes

Upgrade Longhorn chart to v1.5.2.
This upgrade is required to be able to add recurring jobs to automate filesystem trim.
Upgrading from v1.4.x to v1.5.x is straight forward and can be done in-place (cf. https://longhorn.io/docs/1.5.3/deploy/upgrade/longhorn-manager/ and tested on SKS cluster)

Breaking change

  • No
  • Yes (in the Helm chart(s)): indicate the chart, version & release note link
  • Yes (in the module itself): give an explanation of the breaking change

Tests executed on which distribution(s)

  • KinD
  • AKS (Azure)
  • EKS (AWS)
  • Scaleway
  • SKS (Exoscale)

@hbollon hbollon requested a review from a team as a code owner January 23, 2024 09:50
@lentidas
Copy link
Contributor

lentidas commented Jan 23, 2024

@hbollon I've had this upgrade on the pipeline for a while in the PR #12. While an upgrade in-place does work, there are some problems with the chart that prevent it from being deployed on a cluster bootstrap. I do not recall precisely what the problem was, but I remember they were expecting to fix it on the v1.6.0 of the chart. Do you mind if I test the new version on a bootstrap before merging this?

@lentidas
Copy link
Contributor

This is the comment I made on the other PR about the issue, I'll need to restart my research about the issue to freshen up my memory... -> #12 (comment)

@hbollon
Copy link
Member Author

hbollon commented Jan 24, 2024

I can wait until v1.6.0
My cluster is currently deployed on the pre-release/v3.1.0 branch where I merged my PRs to be able to keep working until the v3.1.0 (or v4 depending of the final changelog) is released 👍

@hbollon
Copy link
Member Author

hbollon commented Jan 25, 2024

Closed in favor of #12

@hbollon hbollon closed this Jan 25, 2024
@lentidas lentidas deleted the feat/upgrade-chart branch January 26, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants