feat(alertmanager): add PVC for silences persistance #138
+102
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lentidas
reviewed
Dec 19, 2024
locals.tf
Outdated
| accessModes = ["ReadWriteOnce"] | ||
| resources = { | ||
| requests = { | ||
| storage = "2Gi" |
There was a problem hiding this comment.
I would increase the size of this PVC to at least 10Gi. I know it's way over the required amount, but sadly, if we want to use Exoscale's block storage in the future, they don't allow volumes smaller than 10Gi.
If that's too big for you, then I would create a variable, set the default at 10Gi and you could then overload it on you side depending on the use cases.
neilamumi
force-pushed
the
BGIS-1593-persistence-alertmanager
branch
from
0259d34 to
558f1af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Alertmanager silences were lost on pod or node restarts. By adding a PVC with a default size of 10Gi, silences will now persist across restarts. This storage size can be adjusted by overriding the alertmanager_storage_size variable if we want to
Breaking change
No