Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add variables to set AppProject, labels and destination cluster #22

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

lentidas
Copy link
Contributor

@lentidas lentidas commented Sep 15, 2023

Description of the changes

This PR:

  • Adds the required variables and configuration to allow the module to be deployed on a different cluster than Argo CD.
  • Adds the possibility of placing the application inside a specified Argo CD project in order to avoid having a single project for each application throughout multiple clusters.
  • Adds labels and a variable to add more labels to the Argo CD application to make it easier to sort applications on the web interface of Argo CD.

All these changes are made in preparation for having a centralized Argo CD that controls applications throughout multiple clusters.

⚠️ Do a Rebase and merge.

Breaking change

  • No

Tests executed on which distribution(s)

  • EKS (AWS)

@lentidas lentidas requested a review from a team as a code owner September 15, 2023 12:39
@lentidas lentidas self-assigned this Sep 15, 2023
@lentidas lentidas changed the title Isdevops 243 cluster destination variable feat: add variables to set AppProject, labels and destination cluster Sep 15, 2023
@lentidas lentidas merged commit e353c7f into main Oct 19, 2023
@lentidas lentidas deleted the ISDEVOPS-243-cluster-destination-variable branch October 19, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants