Don't do 2 SQL updates per editing #11232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
force-pushed
the
extend_existing-GSSIT-114
branch
12 times, most recently
from
3d62ecb to
f3e639d
Compare
sbrunner
changed the title
sbrunner
changed the title
sbrunner
force-pushed
the
extend_existing-GSSIT-114
branch
2 times, most recently
from
17917cf to
902b118
Compare
There was a problem hiding this comment.
I understand things.
Note that actually we get two requests (INSERT + UPDATE or UPDATE + UPDATE) but only one commit.
You also fix another issue, conflict when table already exist in DeclarativeMeta using option keep_existing. I would have added it in description and maybe in changelog.
Main subject could also be added to changelog IMHO.
sbrunner
force-pushed
the
extend_existing-GSSIT-114
branch
8 times, most recently
from
eb65876 to
4658a01
Compare
|
@arnaud-morvan ready for a new pass :-) |
arnaud-morvan
approved these changes
Sep 11, 2024
sbrunner
force-pushed
the
extend_existing-GSSIT-114
branch
2 times, most recently
from
2774671 to
c2b403b
Compare
In papyrus there is a flush that create a first commit The idea is to update the fields in the before_* callback to avoid having tow commits
sbrunner
force-pushed
the
extend_existing-GSSIT-114
branch
from
c2b403b to
b30a45e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be able to use existing table
Don't do 2 updates per editing:
In papyrus, there is a flush that creates a first INSERT or UPDATE
The idea is to update the fields in the before_* callback to avoid having two REQUESTS
See JIRA issue: GSSIT-114.