Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of COG layers #11054

Merged
merged 10 commits into from
Jul 10, 2024
Merged

Add support of COG layers #11054

merged 10 commits into from
Jul 10, 2024

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Apr 18, 2024

See JIRA issue: GEO-7032.

Copy link

See also: GEO-7032

@sbrunner sbrunner force-pushed the geo-7032-cog branch 29 times, most recently from a6eadf2 to cb09fa2 Compare April 22, 2024 15:55
@sbrunner sbrunner force-pushed the geo-7032-cog branch 3 times, most recently from af784e4 to bf50bae Compare April 24, 2024 10:20
@sbrunner sbrunner marked this pull request as ready for review April 24, 2024 12:00
@sbrunner sbrunner requested review from arnaud-morvan, ger-benjamin, vuilleumierc and llienher and removed request for arnaud-morvan April 24, 2024 12:00
@yjacolin yjacolin requested review from arnaud-morvan and removed request for arnaud-morvan July 10, 2024 07:37
Copy link
Member

@arnaud-morvan arnaud-morvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

There might be some metadata relevant for COG layers:

See https://github.com/camptocamp/c2cgeoportal/blob/master/admin/config.yaml#L21

And https://github.com/camptocamp/c2cgeoportal/blob/master/geoportal/c2cgeoportal_geoportal/scaffolds/update/%7B%7Bcookiecutter.project%7D%7D/geoportal/CONST_vars.yaml#L513

For example those which contains WMS and WTMS could be relevant example:

  • iconUrl
  • metadataUrl
  • isChecked
  • maxResolution
  • minResolution
  • opacity
  • customOpenLayersOptions

We may have missed this when adding vector tiles layers, so this might also be completed during the pass.

admin/c2cgeoportal_admin/views/layers_cog.py Dismissed Show dismissed Hide dismissed
@sbrunner sbrunner merged commit 80e9194 into master Jul 10, 2024
15 of 16 checks passed
@sbrunner sbrunner deleted the geo-7032-cog branch July 10, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants