Merge pull request #11598 from camptocamp/auth-loop

Don't have an authenticatication loop
camptocamp · Dec 18, 2024 · 2cf265f · 2cf265f
2 parents 315a5d9 + 8084ce2
commit 2cf265f
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/geoportal/c2cgeoportal_geoportal/views/login.py b/geoportal/c2cgeoportal_geoportal/views/login.py
@@ -93,6 +93,9 @@ def _referrer_log(self) -> None:
 
     @forbidden_view_config(renderer="login.html")  # type: ignore[misc]
     def loginform403(self) -> dict[str, Any] | pyramid.response.Response:
+        if self.request.authenticated_userid is not None:
+            return HTTPForbidden()
+
         if self.authentication_settings.get("openid_connect", {}).get("enabled", False):
             return HTTPFound(
                 location=self.request.route_url(
@@ -101,9 +104,6 @@ def loginform403(self) -> dict[str, Any] | pyramid.response.Response:
                 )
             )
 
-        if self.request.authenticated_userid is not None:
-            return HTTPForbidden()
-
         set_common_headers(self.request, "login", Cache.PRIVATE_NO)
 
         return {