feat: use global var and remove group facts #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabelenda
requested changes
Jul 19, 2024
roles/satellite/tasks/define.yml
Outdated
| when: g_test_lifecycleenvironment_defined and g_prod_lifecycleenvironment_defined | ||
| target_lce_name: "{{ prod_lifecycleenvironment }}" | ||
| source_lce_name: "{{ test_lifecycleenvironment }}" | ||
| when: test_lifecycleenvironment_defined and prod_lifecycleenvironment_defined |
There was a problem hiding this comment.
I think you should directly use the "variable is defined" statement instead of using the facts.
This indirection makes things a bit harder to understand and the amount of text it adds here is not excessive.
This would mean removing completely these facts and the file that creates these facts.
There was a problem hiding this comment.
OK. I updated the PR.
jiayuchen888
force-pushed
the
jch_modif_facts
branch
from
0038ad9 to
0338b81
Compare
jiayuchen888
force-pushed
the
jch_modif_facts
branch
from
0338b81 to
4c1272a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.