Support for Cloudwatch dimensions #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do beg your pardon, I've completely missed this pull request! I agree, dimensions are a priority. I'm just not sure the format is ideal. Also I'm sure your code could be clearer. I'll take a look at it soon. |
|
@camitz hi, do you plans to merge this pr? |
|
At the moment there are conflicts with some recent pulls. Also I'm not confortable with the suggested string format. I would prefer being able to do this: App.Controller.Action.Request.donuts:sprinkled.carpet:striped:1|c |
|
Thank you for the interest in this PR. @camitz 's concerns are very valid. However, unfortunately, I am not planning to put any time on this for the time being. |
|
You have my sincerest blessing! |
|
Absolutely @jotes , go forth! |
camitz
pushed a commit
that referenced
this pull request
Oct 8, 2016
send accumulated metrics as an array instead of one at a time... save…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed the ability of using Cloudwatch dimensions. With the changes, dimensions can be specified in the configuration file, i.e.:
cloudwatch:
{
accessKeyId: 'xxx',
secretAccessKey: 'yyy',
region:"US_EAST_1",
processKeyForNamespace: true,
dimensions:[
{ "Name": "Instance", "Value": "i-2bc24da" }
]
}
Dimensions can also be specified in the statistic name:
Namespace.__dimension1_value1.__dimension2_value2.latency:300|ms
Additionally, a string may be provided to the "processKeyForNamespace" option, so instead of splitting the stat name as usual, the provided string will be used for building another regexp that will be used for splitting.