Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore FileNotFoundError when removing the lock file #116

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xuhcc
Copy link
Contributor

@xuhcc xuhcc commented Feb 19, 2020

Related issue: #115

@cameronmaske
Copy link
Owner

cameronmaske commented Feb 20, 2020

@xuhcc Thanks for the quick PR on this.
My only concern is that we are silently suppressing this.
I wonder if it's worth adding a warning or log of some sort to indicate the lock was removed prematurely?
Else, users who encounter this will most likely just assume the lock isn't working.
Any thoughts?

@xuhcc
Copy link
Contributor Author

xuhcc commented Feb 21, 2020

I agree that some kind of warning certainly would be useful in this case, but I'm not sure how to implement it. It seems that celery-once doesn't currently employ the logging module.

@cameronmaske
Copy link
Owner

@xuhcc Yeh, fair point. Adding logging is a whole separate improvement and can be tackled later.

@eyeteajay
Copy link

Hello, do you know how much "later" it will be to merge & release this?
It's nearly 2 years later but I'm getting the same traceback as described in #115 with version 3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants