Refactor CamelDebuggerSession: Simplify breakpoint handling and improve clarity in path modification logic #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… run configuration by introducing explaining variable and extracting method for improved clarity
…s and decompose conditions in CamelDebuggerSession
…ells Refactor/implementation smells
refactor: replace conditional logic in breakpoint handling with polymorphism
essobedo
reviewed
Nov 28, 2024
| import java.util.Map; | ||
|
|
||
| public final class FileTypeHandlerRegistry { | ||
| private static final Map<String, FileTypeHandler> HANDLERS = new HashMap<>(); |
There was a problem hiding this comment.
You can use Map.of instead
There was a problem hiding this comment.
The project mainly uses HashMap for consistency. So I just stick with that to maintain uniformity
refactor: resolve design smell using pull-up method and extract class
|
What is your reason for sending this PR? This is a IDE plugin for users of Apache Camel. Are you using Apache Camel? We are looking for actual end users of Apache Camel that wants to improve this plugin with new features and improvements that make this plugin better for every Camel end users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several important changes to the Camel plugin codebase, focusing on refactoring and improving the structure of language handling and completion providers. The most significant changes include the introduction of abstract completion providers, the extraction of language classes into separate files, and the addition of a file type handler registry for breakpoints.
Refactoring and Code Structure Improvements:
src/main/java/com/github/cameltooling/idea/completion/contributor/CamelContributor.java: IntroducedAbstractCompletionProviderto replace the existingEndpointCompletionandPropertiesCompletionclasses, and refactored their implementations to extend this new abstract class. [1] [2]Language Handling:
src/main/java/com/github/cameltooling/idea/language/CamelLanguages.java: Removed inner language classes (DatasonnetLanguage,SimpleLanguage,ConstantLanguage) and their associated methods.src/main/java/com/github/cameltooling/idea/language/ConstantLanguage.java: AddedConstantLanguageclass as a standalone file.src/main/java/com/github/cameltooling/idea/language/DatasonnetLanguage.java: AddedDatasonnetLanguageclass as a standalone file.src/main/java/com/github/cameltooling/idea/language/SimpleLanguage.java: AddedSimpleLanguageclass as a standalone file.Breakpoint Handling:
src/main/java/com/github/cameltooling/idea/runner/debugger/breakpoint/CamelBreakpointType.java: Replaced the switch statement with aFileTypeHandlerRegistryto handle different file types for breakpoints.src/main/java/com/github/cameltooling/idea/runner/debugger/breakpoint/FileTypeHandler.java: IntroducedFileTypeHandlerinterface for handling different file types.src/main/java/com/github/cameltooling/idea/runner/debugger/breakpoint/FileTypeHandlerRegistry.java: AddedFileTypeHandlerRegistryto manage file type handlers.These changes collectively improve the maintainability and extensibility of the codebase by modularizing language definitions, abstracting common functionalities, and centralizing file type handling logic.