Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance source2synth #1464

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: enhance source2synth #1464

wants to merge 5 commits into from

Conversation

Wendong-Fan
Copy link
Member

@Wendong-Fan Wendong-Fan commented Jan 18, 2025

Description

Refactor and enhance source2synth module based on review comment #1289 (comment)

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan self-assigned this Jan 18, 2025
@Wendong-Fan Wendong-Fan added the enhancement New feature or request label Jan 18, 2025
@Wendong-Fan Wendong-Fan added this to the Sprint 21 milestone Jan 18, 2025
@Wendong-Fan Wendong-Fan marked this pull request as ready for review January 18, 2025 21:53
Copy link
Collaborator

@zjrwtx zjrwtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wendong-Fan thanks !look good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants