no longer override Apache's default 401 page text #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apache lacks a proper core API for modules to override the default text, so this was a fragile hack. Instead, advise users to use AuthzSendForbiddenOnFailure On such that authorization failure is reported via the more appropriate 403 status code and page. This will make future breakage such as issue cambridgeuniversity#11 less likely whenever Apache next changes their ErrorDocument data structures. Note that AuthzSendForbiddenOnFailure was only introduced in Apache 2.3.11, so Apache 2.2 users may prefer not to apply it.
|
Given that AuthzSendForbiddenOnFailure is only available in Apache 2.4 and that 2.2 is still in use and just about supported by Apache I think it would be inappropriate to merge this change at the moment. Further, it has the downside that users will receive the default confusing Apache message unless administrators read the documentation and take action -- not things that always happen. |
|
The Apache HTTP Server Project discontinued all development and patch review of the 2.2.x series of releases on 2018-01-01. Therefore I suggest that future releases of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apache lacks a proper core API for modules to override the default
text, so this was a fragile hack. Instead, as suggested in issue #16, advise users to use
such that authorization failure is reported via the more appropriate
403 status code and page. This will make future breakage such as issue #11
less likely whenever Apache next changes their ErrorDocument data structures.
Note that AuthzSendForbiddenOnFailure was only introduced in Apache 2.3.11,
so Apache 2.2 users may prefer not to apply this patch.