Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve deploy scripts and allow for profiling memory performance #105

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

mfekadu
Copy link
Member

@mfekadu mfekadu commented Mar 2, 2020

What's New?

Related to #103

Progress toward #101

Type of change (pick-one)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • probably a good idea to document how to use memory-profiler in the README
    • probably a good idea to document how the deploy scripts work in the README

How Has This Been Tested?

Screenshots

notice the color when user forgets to set environment variables

image

also colorful when environment variables are empty string on accident

image

Checklist (check-all-before-merge)

formatting help: - [x] means "checked' and - [ ] means "unchecked"

  • I documented my code according to the Google Python Style Guide

  • I ran ./build_docs.sh and the docs look fine

  • I ran ./type_check.sh and got no errors

  • I ran ./format.sh because it automatically cleans my code for me 😄

  • I ran ./lint.sh to check for what "format" missed

  • I added my tests to the /tests directory

  • I ran ./run_tests.sh and all the tests pass

@mfekadu mfekadu changed the title Mf improve deploy scripts and profile performance improve deploy scripts and profile performance Mar 2, 2020
@mfekadu mfekadu changed the title improve deploy scripts and profile performance improve deploy scripts and allow for profiling performance Mar 2, 2020
@mfekadu mfekadu changed the title improve deploy scripts and allow for profiling performance improve deploy scripts and allow for profiling memory performance Mar 2, 2020
Copy link
Member

@snekiam snekiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a nice QOL change!

Copy link
Contributor

@Jason-Ku Jason-Ku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@snekiam
Copy link
Member

snekiam commented Jun 14, 2020

@mfekadu Is this something that still needs to be merged? I know we added color stuff in a later PR, and I think our memory issues are at least better than they were. Going back and cleaning up old PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants