-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force utf 8 encoding on writes #163
Conversation
- Added `encoding="utf-8"` to all writes.
Version hint: patch Comment ID: Display the version hint-auto-generated |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #163 +/- ##
=======================================
Coverage 93.44% 93.44%
=======================================
Files 24 24
Lines 1479 1479
Branches 295 295
=======================================
Hits 1382 1382
Misses 68 68
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I think it's related to my issue, I get this on bump all of a sudden: bump-my-version bump minor
Exception in thread Thread-25 (_readerthread):
Traceback (most recent call last):
File "C:\Users\User\.pyenv\pyenv-win\versions\3.11.3\Lib\threading.py", line 1038, in _bo
otstrap_inner
self.run()
File "C:\Users\User\.pyenv\pyenv-win\versions\3.11.3\Lib\threading.py", line 975, in run
self._target(*self._args, **self._kwargs)
File "C:\Users\User\.pyenv\pyenv-win\versions\3.11.3\Lib\subprocess.py", line 1568, in _r
eaderthread
buffer.append(fh.read())
^^^^^^^^^
File "C:\Users\User\.pyenv\pyenv-win\versions\3.11.3\Lib\encodings\cp1252.py", line 23, i
n decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 20: character maps t
o <undefined> |
Fixes #157
The problem was that it failed to write the configuration file because of a character-encoding problem. This forces all writes to use UTF-8.