Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force link between flow cap and purchased units in base math #566

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

brynpickering
Copy link
Member

Equivalent fix to the issue raised in #565.

Summary of changes in this pull request:

  • Link purchased_units with flow_cap even when flow_cap_max has not been set by the user. Uses bigM to achieve this.

Reviewer checklist:

  • Test(s) added to cover contribution
  • Documentation updated
  • Changelog updated
  • Coverage maintained or improved

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36466f9) 95.76% compared to head (b8ed034) 95.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #566   +/-   ##
=======================================
  Coverage   95.76%   95.76%           
=======================================
  Files          24       24           
  Lines        3566     3566           
  Branches      777      711   -66     
=======================================
  Hits         3415     3415           
  Misses         86       86           
  Partials       65       65           

@brynpickering brynpickering merged commit 0e12b05 into main Feb 13, 2024
12 checks passed
@brynpickering brynpickering deleted the fix-purchase-constraint branch February 13, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants