Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handles composer.json files when Pest is set as an allowable plugin #138

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Handles composer.json files when Pest is set as an allowable plugin #138

merged 5 commits into from
Oct 11, 2023

Conversation

joedixon
Copy link
Contributor

@joedixon joedixon commented Oct 11, 2023 •
edited
Loading

Previously, the extension would use the Pest binary if the following was present in the composer.json.

"config": {
    "allow-plugins": {
        "pestphp/pest-plugin": true
    }
}

This PR resolves that issue by explicitly checking for "pestphp/pest" rather than pestphp/pest (notice the quotes).

@joedixon joedixon changed the title Fix/handle pest allow plugins Handles composer.json files when Pest is set as an allowable plugin Oct 11, 2023
@joedixon joedixon marked this pull request as ready for review October 11, 2023 07:26
@joedixon joedixon mentioned this pull request Oct 11, 2023
Merged
@calebporzio calebporzio merged commit 9ce107b into calebporzio:master Oct 11, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joedixon @calebporzio