Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESM support #104

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add ESM support #104

wants to merge 4 commits into from

Conversation

Lodin
Copy link
Collaborator

@Lodin Lodin commented Jan 31, 2022

Resolves #93

@Lodin Lodin marked this pull request as ready for review January 31, 2022 10:39
@Lodin Lodin requested a review from calebdwilliams January 31, 2022 10:39
@Lodin
Copy link
Collaborator Author

Lodin commented Jan 31, 2022

@calebdwilliams, I wonder what would be better: to use .mjs in module field or to remove module field completely in favor of exports field? What do you think?

@codecov-commenter
Copy link

Codecov Report

Merging #104 (f4208ad) into main (e6c5177) will not change coverage.
The diff coverage is n/a.

❗ Current head f4208ad differs from pull request most recent head b4b294e. Consider uploading reports for the commit b4b294e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files           5        5           
  Lines         189      189           
  Branches       32       32           
=======================================
  Hits          174      174           
  Misses          4        4           
  Partials       11       11           
Flag Coverage Δ
unittests 92.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6c5177...b4b294e. Read the comment docs.

@calebdwilliams
Copy link
Owner

@Lodin in my experience exports is spotty until everything adopts [email protected]. I’d definitely mark that as a to-do but maybe not right away unless it’s absolutely needed.

@calebdwilliams
Copy link
Owner

Also @Lodin let me know when this is final and I’ll try it out locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants