[navigation] revamp bottom tab bar and header #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to philipye314/imp-78-revamp-bottom-tab-bar-and-header
ronniebeggs
reviewed
Apr 14, 2024
ronniebeggs
requested changes
Apr 14, 2024
ronniebeggs
changed the title
…ttps://github.com/calblueprint/impact-fund into philipye314/imp-78-revamp-bottom-tab-bar-and-header
ronniebeggs
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
I removed the disappearing bottom tab and applied header styles to all screens in the app. Would you mind double checking that all screens have the correct headers shown on Figma? The styling on most input screens will look off but Melissa is fixing that in her PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
Screenshots
How to review
Next steps
Relevant Links
https://reactnavigation.org/docs/bottom-tab-navigator/
https://reactnavigation.org/docs/native-stack-navigator/
https://stackoverflow.com/questions/56745881/how-to-hide-bottom-navigation-bar-on-a-specific-screen-in-react-native
CC: @ronniebeggs