Share button #76
Open
Share button #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronniebeggs
requested changes
Apr 4, 2024
Comment on lines
31
to
33
| const addCaseUrl = Linking.createURL('?event=addCase&', { | ||
| queryParams: { caseUid }, | ||
| }); |
There was a problem hiding this comment.
event=addCase is technically a query parameter, so maybe we can clean up this function instead of concatenating multiple partial strings.
src/app/(BottomTabNavigation)/AllCases/CaseScreen/[caseUid].tsx
Outdated
Show resolved
Hide resolved
Comment on lines
36
to
38
| await Share.share({ | ||
| //message: 'ADD CASE', | ||
| url: `${addCaseUrl}/`, |
There was a problem hiding this comment.
Out of curiosity, is there anyway to customize how the link looks when shared with someone? Sometimes apps will attach an image or additional text to the link so users don't have to see the entire link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
Screenshots
How to review
Next steps
Relevant Links
Online sources
Related PRs
Deep Linking Base
CC: @ronniebeggs