Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent fatal error on reserved keywords as migration names. #780

Merged
merged 4 commits into from
Nov 30, 2024
Merged

Prevent fatal error on reserved keywords as migration names. #780

merged 4 commits into from
Nov 30, 2024

Conversation

dereuromark
Copy link
Member

Resolves #693

reservd

@dereuromark dereuromark added this to the 4.x (CakePHP 5) milestone Nov 29, 2024
@markstory
Copy link
Member

Looks good, we should have a test for this scenario though.

@dereuromark dereuromark mentioned this pull request Nov 29, 2024
Closed
@dereuromark
Copy link
Member Author

Test added

@markstory markstory merged commit fd4ee78 into 4.x Nov 30, 2024
16 checks passed
@markstory markstory deleted the 4.x-reserved-keywords branch November 30, 2024 16:25
@MasterOdin MasterOdin mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.x (CakePHP 5)
Development

Successfully merging this pull request may close these issues.

Bake migration snapshot should not allow reserved words
2 participants
@dereuromark @markstory