-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid timestamp collisions on bake. #773
Conversation
This is BC breaking. Anyone who has already overwritten those classes and added their own arguments will have to adjust their implementation. |
Only for those that overwrote the Migration plugin command here, and also exactly that method with a different param. |
To me the 'public' API of migrations is the migrations classes and the CLI interface. While this would be a breaking change in the core framework, I don't think similar rules have to apply here. |
I could definitely think of users who overwrote the Sure, it ain't everyone out there, but it goes against semantic versioning which we religiously comply with (at least with the major changes I tried to do in the past). Not that I am against trying to fix this bug and maybe cause a few hickups for a few users, it's just inconsistent imho. |
In the end it should be easy enough to adjust to this minor release. |
The state could be shared via a property instead of an additional argument. Then its just the currentTimestamp overwrite which could cause problems. |
I made a PR to this one that should provide BC. |
* Fix BC topic. * Fix BC topic.
Resolves #772