Merge pull request #726 from cakephp/fix-725

Check for potentially undefined command line argument
cakephp · Jul 4, 2024 · 364b0b0 · 364b0b0
2 parents 3e3b537 + b095acf
commit 364b0b0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -22,10 +22,14 @@ jobs:
         php-version: ['8.1', '8.2']
         db-type: [mysql, pgsql, sqlite]
         prefer-lowest: ['']
+        cake_version: ['']
         include:
           - php-version: '8.1'
             db-type: 'sqlite'
             prefer-lowest: 'prefer-lowest'
+          - php-version: '8.1'
+            db-type: 'sqlite'
+            cake_version: 'dev-5.next as 5.1.0'
 
     services:
       postgres:
@@ -89,6 +93,9 @@ jobs:
             composer install --ignore-platform-req=php
           elif ${{ matrix.prefer-lowest == 'prefer-lowest' }}; then
             composer update --prefer-lowest --prefer-stable
+          elif ${{ matrix.cake_version != '' }}; then
+            composer require --dev "cakephp/cakephp:${{ matrix.cake_version }}"
+            composer update
           else
             composer update
           fi

diff --git a/src/Migration/Manager.php b/src/Migration/Manager.php
@@ -302,7 +302,10 @@ public function getVersionsToMark(Arguments $args): array
         $migrations = $this->getMigrations();
         $versions = array_keys($migrations);
 
-        $versionArg = $args->getArgument('version');
+        $versionArg = null;
+        if ($args->hasArgument('version')) {
+            $versionArg = $args->getArgument('version');
+        }
         $targetArg = $args->getOption('target');
         $hasAllVersion = in_array($versionArg, ['all', '*'], true);
         if ((empty($versionArg) && empty($targetArg)) || $hasAllVersion) {