Deprecate methods #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
delamux
commented
Feb 17, 2024
delamux
commented
- Refactor and remove deprecated methods
steinkel
requested changes
Feb 19, 2024
src/Utility/NotificationManager.php
Outdated
| } | ||
|
|
||
| foreach ((array)$data['users'] as $user) { | ||
| $entity = $model->newEntity(); | ||
| $model->saveMany($entities); |
There was a problem hiding this comment.
good point, I will handle the error.
| $item->set('state', 0); | ||
| $model->save($item); | ||
| $item->set('state', Notification::READ_STATUS); | ||
| $this->table->save($item); |
delamux
commented
Feb 20, 2024
| foreach ((array)$data['users'] as $userId) { | ||
| $finalData = array_merge($data, ['user_id' => $userId]); | ||
| $entity = $model->newEntity($finalData); | ||
| $entity->set('vars', $data['vars']); |
There was a problem hiding this comment.
By the way, I needed it to do this because for any reason, passing the data in the newEntities with the arrays of arrays was not entering in the property 'vars' of the Entity which is in charge of jsonEncode. Was setting up the vars as empty string
src/Utility/NotificationManager.php
Outdated
| } | ||
|
|
||
| foreach ((array)$data['users'] as $user) { | ||
| $entity = $model->newEntity(); | ||
| $model->saveMany($entities); |
There was a problem hiding this comment.
good point, I will handle the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.