Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CW 781 replace all print statements with printV #1733

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

CW 781 replace all print statements with printV #1733

wants to merge 6 commits into from

Conversation

MrCyjaneK
Copy link
Collaborator

Description

Goals:

  • Replace all print statements with printV
  • Show caller (path/file:line:column functionName)
  • Add an action that makes sure that no normal print statement is being used in dart files (printV is a drop-in replacement and using print statements would make debugging harder in the future)
  • Optional: At little cost I can implement logging to file, with timestamps and details - we could use that in error reporting screen)

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods

@MrCyjaneK MrCyjaneK force-pushed the CW-781-improve-logging branch 4 times, most recently from 923a183 to 5f0dc90 Compare October 8, 2024 08:15
@MrCyjaneK MrCyjaneK changed the title replace all print statements with printV CW 781 replace all print statements with printV Nov 26, 2024
OmarHatem28
OmarHatem28 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@OmarHatem28 OmarHatem28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge it after this release as it will probably cuz a lot of conflicts with other PRs

cw_core/lib/utils/print_verbose.dart Outdated Show resolved Hide resolved
cw_core/lib/utils/print_verbose.dart Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarHatem28 OmarHatem28 OmarHatem28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrCyjaneK @OmarHatem28