(GH-76) fixed codeql-analysis #77
Conversation
| uses: actions/cache@v2 | ||
| with: | ||
| path: tools | ||
| key: ${{ runner.os }}-tools-${{ hashFiles('recipe.cake') }} |
There was a problem hiding this comment.
Not for this PR in particular, but in general, would it make sense to also cache the NuGet cache folder, so that dependencies that are imported via PackageReference are also cached?
I imagine you'd have to include the .csproj files in the hash as well to purge the cache when they change too. Prob. global.json as well 🤔
e.g.
key: ${{ runner.os }}-${{ hashFiles('recipe.cake', 'global.json', 'source/**/*.csproj') }}There was a problem hiding this comment.
I think you're right.
I opened up cake-contrib/Cake.Recipe#815 for that - I'd like to document that before we start implementing it 😄
There was a problem hiding this comment.
Don't think we would need to update the hash files would we? We run dotnet/NuGet restore each build, so if there are missing dependencies they will be pulled in without needing to bust the cache. No?
There was a problem hiding this comment.
Good question. I think you're right in the sense that dotnet restore would pull new versions into the cache as needed.
When it comes to transitive dependencies in a scenario that nuget.org is offline (or not accessible from the CI server), is it guaranteed that nuget won't use the nearest version in the cache?
Growth is not a concern, I think, as it would be almost impossible to hit the 5 GB limit in most Cake projects unless they have nightly runs set up.
fixes #76