GH-2101: Disable report printing if verbosity of logger is Quiet #4148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
augustoproiete
changed the title
augustoproiete
requested changes
Apr 19, 2023
| { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Thanks for the PR @deniszykov! As you can see in this comment in the original issue we wouldn't want to change the semantics of the Quiet verbosity in order to hide the report - this means users don't have a way to suppress the log messages and see the report anymore.
Could you add a new command-line argument to Cake called --no-report that hides the report? (regardless of the Verbosity)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #2101