Update shared.py to handle the amount of fields for lbm scans #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, shared.Field() is created with 25 fields. This is not sufficient to handle the expected range of fields per scan for LBM scans. Current expected range is 120-150 fields, although 150 is not a hard limit.
Additionally, the datatype used in this table should be changed from tinyint to smallint, as tinyint only has a range of (-128 to 127). smallint has a more-than-sufficient range of (-32,768 to 32,767).
This table will likely not be re-created prior to the development of a/the new pipeline. I'm making this PR to remind those in the future to consider this when making design choices for that new pipeline. Feel free to leave this PR un-approved until that time.