Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#45 add timeout to train job #46

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ibm-peach-fish
Copy link
Collaborator

closes #45

@kellyaa
Copy link
Member

kellyaa commented Oct 25, 2023

Looks like a good approach. Two things:

  • Can you add a unit test that tests setting the timeout and makes sure the job ends at the timeout? We'll probably also want to make sure that when we call get_info() on the RayTrainModelFuture after the job times out, that is returns an expected state.
  • Run tox -e fmt on your dev env and let it modify your file to make the linter happy before doing to next commit!

@ibm-peach-fish
Copy link
Collaborator Author

thanks for the quick review @kellyaa

ack on the unit test, i'll do that this morning

i did do the tox -e fmt and tox -e lint before i committed, then didn't go back to check it worked. I will next time and tinker with it if it still gives me bad noise

Signed-off-by: Trevor Grant <[email protected]>
Signed-off-by: Trevor Grant <[email protected]>
Signed-off-by: Trevor Grant <[email protected]>
@ibm-peach-fish ibm-peach-fish self-assigned this Oct 30, 2023
@ibm-peach-fish
Copy link
Collaborator Author

@kellyaa this is ready for (re)review

Copy link
Member

@kellyaa kellyaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RAY] timeout mechanism for job length or long queues
2 participants