-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pointer constraint. #300
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR @vanfanel. I am just taking a (very) quick look at it. Could you run |
Done. It was my first time using that tool, seems very useful indeed. The more you know! |
@joggee-fr any news on merging this, please? |
@vanfanel, I am not confident enough in my knowloedge for this part to give it a go. I hope @emersion could give it a look. Especially for the so-called "big hack" part. |
9cffcd6
to
7bf842f
Compare
@joggee-fr I have done what you asked me: I rebased to latest Cage code, and squashed all commits into one. And yes, the "big hack" part is needed with current wlroots 0.17, it comes directly from current Sway, you can see it here: |
1913ba7
to
3f72f1e
Compare
@joggee-fr I have fixed those comment-related issues you pointed me to, and squashed all commits again. |
@joggee-fr Is there anything else to get this merged, please? |
This PR doesn't seem to work? I hope that I'm just doing something wrong.
|
It definitely worked with Minecraft before, we used it last summer to run Minecraft at Gamescom. |
Using that fork doesn't work either. Same results as with this. Is it supposed to "just work" or do I have to use a keybind or something? |
Implements the previously missing pointer constraint functionality.
Most code came from Sway.