Localize list tabs' routes #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MatejBalantic
commented
May 18, 2015
MatejBalantic
commented
- This adds ability to localize individual tab's route
- Also removes hard-coded list of tabs from few places in favor of enum
- This adds ability to localize individual tab's route - Also removes hard-coded list of tabs from few places in favor of enum
| result.include("tabs", this.tabsHelper.getTabs()); | ||
| result.include("questions", top); | ||
| result.include("currentUser", loggedUser); | ||
| result.forwardTo("/WEB-INF/jsp/list/top.jsp"); |
There was a problem hiding this comment.
Any reasons to remove the section include?
There was a problem hiding this comment.
I haven't seen it would be used anywhere, I'll double check this, thanks
|
@leocwolter Thanks for looking into this! |
|
Hi @MatejBalantic! Are you planning to address the comments made by @leocwolter? This PR is pretty useful, would be great if you could fix this small issues to ship that to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.