Move tcheck to go.mod, get rid of glide dependency #3999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
tcheck
branch
from
2dcf6cb to
5c1bd5a
Compare
yux0
approved these changes
Feb 18, 2021
github-actions
bot
force-pushed
the
tcheck
branch
4 times, most recently
from
30e26cb to
aa6754c
Compare
github-actions
bot
force-pushed
the
tcheck
branch
from
aa6754c to
992de7f
Compare
longquanzheng
pushed a commit
that referenced
this pull request
Mar 1, 2021
[glide.sh is down](Masterminds/glide#1077), breaking our pipelines, and glide is abandonware anyway. It's well past time to migrate off. I don't believe `tcheck` is actually used for anything, nor is it mentioned in any documentation... but it _does_ work, it'll tell you if e.g. cadence-frontend is running and could be useful for scripting. Though in that case a relevant `cadence ...` command would be as good or better anyway. It may be worth removing this entirely? It's not particularly large nor pulling in any new dependencies, but it may just be old cruft.
yycptt
pushed a commit
that referenced
this pull request
Mar 29, 2021
[glide.sh is down](Masterminds/glide#1077), breaking our pipelines, and glide is abandonware anyway. It's well past time to migrate off. I don't believe `tcheck` is actually used for anything, nor is it mentioned in any documentation... but it _does_ work, it'll tell you if e.g. cadence-frontend is running and could be useful for scripting. Though in that case a relevant `cadence ...` command would be as good or better anyway. It may be worth removing this entirely? It's not particularly large nor pulling in any new dependencies, but it may just be old cruft.
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
…3999) [glide.sh is down](Masterminds/glide#1077), breaking our pipelines, and glide is abandonware anyway. It's well past time to migrate off. I don't believe `tcheck` is actually used for anything, nor is it mentioned in any documentation... but it _does_ work, it'll tell you if e.g. cadence-frontend is running and could be useful for scripting. Though in that case a relevant `cadence ...` command would be as good or better anyway. It may be worth removing this entirely? It's not particularly large nor pulling in any new dependencies, but it may just be old cruft.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glide.sh is down, breaking our pipelines, and glide is abandonware anyway.
It's well past time to migrate off.
I don't believe
tcheckis actually used for anything, nor is it mentioned in any documentation... but it does work, it'll tell you if e.g. cadence-frontend is running and could be useful for scripting. Though in that case a relevantcadence ...command would be as good or better anyway.It may be worth removing this entirely? It's not particularly large nor pulling in any new dependencies, but it may just be old cruft.