Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --no-debug-vars command line switch to disable the /debug/var endpoint #67

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

dee-see
Copy link
Contributor

@dee-see dee-see commented Oct 25, 2023

Description

Fixes #66

Checklist

  • Code compiles correctly
  • Created tests (if appropriate)
  • All tests passing
  • Extended the README / documentation (if necessary)

@dee-see dee-see changed the title Patch 1 Add a --no-debug-vars command line switch to disable the /debug/var endpoint Oct 25, 2023
@dee-see
Copy link
Contributor Author

dee-see commented Oct 25, 2023

The tests are actually failing for me locally but it's not related (I think?)

$ make test
Running tests...
?       github.com/cactus/go-camo/v2/cmd/go-camo        [no test files]
?       github.com/cactus/go-camo/v2/cmd/url-tool       [no test files]
--- FAIL: TestUpstreamProxyParsing (0.00s)
    upstream_proxy_test.go:53: assertion failed: 
        --- addresses
        +++ →
          []string{
                "127.0.0.1",
        +       "::1",
          }
        
--- FAIL: TestUpstreamProxyParsing (0.00s)
    upstream_proxy_test.go:53: assertion failed: 
        --- addresses
        +++ →
          []string{
                "127.0.0.1",
        +       "::1",
          }
        
FAIL
FAIL    github.com/cactus/go-camo/v2/pkg/camo   6.197s
ok      github.com/cactus/go-camo/v2/pkg/camo/encoding  0.006s
ok      github.com/cactus/go-camo/v2/pkg/htrie  0.006s
ok      github.com/cactus/go-camo/v2/pkg/router 4.007s
FAIL
make: *** [Makefile:82: test] Error 1

@dropwhile
Copy link
Member

@dee-see yeah, that test can fail in some environments and is unrelated.
PR looks good to me. Thanks!

@dropwhile dropwhile merged commit 6ff454a into cactus:master Oct 25, 2023
2 checks passed
@dee-see dee-see deleted the patch-1 branch October 27, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add a command-line option to remove /debug/vars/ endpoint from metrics
2 participants