Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tasks: reverse task order #1573

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

tasks: reverse task order #1573

wants to merge 5 commits into from
+59 −12

Conversation

sandydoo
Copy link
Member

@sandydoo sandydoo commented Nov 4, 2024 •
edited
Loading

I think we're running the tasks in reverse order after the toposort. The following tasks are speced to run after enterShell, but they instead run before.

Succeeded         devenv:pre-commit:install 25ms
Succeeded         devenv:python:virtualenv  318ms
Succeeded         devenv:enterShell         10ms

This PR lets the graph traversal visit both outgoing and incoming edges.

Fixes #1557.

TODO
  • Update existing tests

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 5, 2024 •
edited
Loading

Deploying devenv with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4fac0ae
Status: ✅  Deploy successful!
Preview URL: https://a1455b11.devenv.pages.dev
Branch Preview URL: https://fix-task-order.devenv.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot run task after poetry install
1 participant
@sandydoo