Skip to content

Commit

Permalink
fix bug: concurrent map writes error
Browse files Browse the repository at this point in the history
  • Loading branch information
lianghao208 committed Nov 21, 2020
1 parent 8c7cd8a commit 42c00bc
Showing 1 changed file with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"context"
"errors"
"fmt"
"sync"
"time"

v1 "k8s.io/api/core/v1"
Expand Down Expand Up @@ -53,6 +54,7 @@ type stateData struct {
// phase for each node
// it's initialized in the PreFilter phase
podVolumesByNode map[string]*scheduling.PodVolumes
sync.Mutex
}

func (d *stateData) Clone() framework.StateData {
Expand Down Expand Up @@ -205,9 +207,10 @@ func (pl *VolumeBinding) Filter(ctx context.Context, cs *framework.CycleState, p
return status
}

cs.Lock()
// multiple goroutines call `Filter` on different nodes simultaneously and the `CycleState` may be duplicated, so we must use a local lock here
state.Lock()
state.podVolumesByNode[node.Name] = podVolumes
cs.Unlock()
state.Unlock()
return nil
}

Expand Down

0 comments on commit 42c00bc

Please sign in to comment.