Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added segment about string types and their corresponding member functions #87

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Nizarll
Copy link

@Nizarll Nizarll commented Nov 14, 2024

i think this segment was pretty important especially since the programming language targets people from a c background so providing an explanation of the underlying implementations .

@Nizarll
Copy link
Author

Nizarll commented Nov 14, 2024

However i'm thinking about making a different segment for member functions of most of the underlying types something similar to cppreference where any type from the standard library or the base types that states all of their member functions shows examples and usage

@lerno lerno requested a review from joshring November 14, 2024 22:07
@joshring
Copy link
Contributor

However i'm thinking about making a different segment for member functions of most of the underlying types something similar to cppreference where any type from the standard library or the base types that states all of their member functions shows examples and usage

A separate section might be good (second PR?), people have also asked about the mathematical operations defined as member functions too.

Copy link
Contributor

@joshring joshring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
Some small bits, added some suggestions to speed things along 👍

src/content/docs/Language Common/strings.md Outdated Show resolved Hide resolved
src/content/docs/Language Common/strings.md Show resolved Hide resolved
src/content/docs/Language Common/strings.md Outdated Show resolved Hide resolved
src/content/docs/Language Common/strings.md Outdated Show resolved Hide resolved
@Nizarll
Copy link
Author

Nizarll commented Nov 15, 2024

However i'm thinking about making a different segment for member functions of most of the underlying types something similar to cppreference where any type from the standard library or the base types that states all of their member functions shows examples and usage

A separate section might be good (second PR?), people have also asked about the mathematical operations defined as member functions too.

i think the first part without the member functions should be kept , but the member functions should probably be in a whole other Section about the standard library's type and the functions as well as examples similar to cppref i will be preparing a second pr this week ! I am still wondering about the name of the section though

@joshring
Copy link
Contributor

What jumps to mind immediately is "Type Member Functions"

src/content/docs/Language Common/strings.md Outdated Show resolved Hide resolved
src/content/docs/Language Common/strings.md Outdated Show resolved Hide resolved
src/content/docs/Language Common/strings.md Outdated Show resolved Hide resolved
@joshring
Copy link
Contributor

Thanks @Nizarll could you apply those above? then we can look to get this merged :)

Nizarll and others added 3 commits November 20, 2024 07:59
Co-authored-by: Josh Ring <[email protected]>
Co-authored-by: Josh Ring <[email protected]>
Co-authored-by: Josh Ring <[email protected]>
@Nizarll
Copy link
Author

Nizarll commented Nov 20, 2024

Alright , done.
I've been preparing the pr for default types member functions it should be done in a few days !

@joshring
Copy link
Contributor

Still a few suggestions left, but nearly there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants