Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more friendly warnings #671

Merged
merged 1 commit into from
Jul 16, 2024
Merged

chore: add more friendly warnings #671

merged 1 commit into from
Jul 16, 2024

Conversation

liuq19
Copy link
Collaborator

@liuq19 liuq19 commented Jul 9, 2024

As the title

@liuq19 liuq19 force-pushed the chore/warnning branch 2 times, most recently from 415a18d to 6dffe80 Compare July 9, 2024 11:44
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.51%. Comparing base (121df0a) to head (af9ecec).
Report is 2 commits behind head on main.

Files Patch % Lines
internal/encoder/vars/errors.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
- Coverage   52.66%   51.51%   -1.16%     
==========================================
  Files         172      143      -29     
  Lines       11334    11391      +57     
==========================================
- Hits         5969     5868     -101     
- Misses       5044     5200     +156     
- Partials      321      323       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AsterDY AsterDY merged commit 125ff79 into main Jul 16, 2024
43 checks passed
@AsterDY AsterDY deleted the chore/warnning branch July 16, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants