Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: didn't pass non-exist value when call Node.Interface() #544

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

AsterDY
Copy link
Collaborator

@AsterDY AsterDY commented Oct 26, 2023

Issue

After Unset() some nodes for its parent, call parent.Interface() will return errors like unsupported type

Reason

That's because since # , sonic/ast didn't delete node memory after Unset() meanwhile Interface() logic counted the actually non-exist node

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Merging #544 (62d514d) into main (de254c3) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #544   +/-   ##
=======================================
  Coverage   78.30%   78.30%           
=======================================
  Files          69       69           
  Lines       10686    10686           
=======================================
  Hits         8368     8368           
  Misses       1955     1955           
  Partials      363      363           
Files Coverage Δ
ast/iterator.go 70.11% <100.00%> (+1.44%) ⬆️
ast/node.go 82.80% <100.00%> (-0.08%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AsterDY AsterDY merged commit 53c974e into main Oct 26, 2023
29 checks passed
@AsterDY AsterDY deleted the fix/any_on_not_exist_node branch October 26, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants