Fix weval.h, and add a smoketest. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfallin
force-pushed
the
cfallin/weval-h-and-smoketest
branch
from
e5cb1b2
to
ac688bc
Compare
cfallin
force-pushed
the
cfallin/weval-h-and-smoketest
branch
from
ac688bc
to
5798a9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings three updates:
It fixes a build error in weval.h, inadvertently introduced during code review and not caught because (i) the wevaling flow is only tested in an indirect integration-test in the SpiderMonkey use-case, and (ii) the vendored copy of weval.h in that repo was never updated with these changes.
It adds a simple integration test to this repo. This is an updated version of the first toy interpreter that weval was co-developed with (and that still exists in the commit history of this repo).
It invokes this "smoke test" in CI.