Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Module::deserialize_open_file #9571

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adambratschikaye
Copy link
Contributor

Add an API to deserialize a Module from an already opened file. This can be useful in situations where wasmtime is running in a sandboxed environment with limited access to the file system. Then another process can handle opening the files and passing them to wasmtime.

Add an API to deserialize a `Module` from an already opened file. This
can be useful in situations where `wasmtime` is running in a sandboxed
environment with limited access to the file system. Then another process
can handle opening the files and passing them to `wasmtime`.
@adambratschikaye adambratschikaye changed the title Add Module::from_trusted_open_file Add Module::deserialize_open_file Nov 6, 2024
@adambratschikaye adambratschikaye marked this pull request as ready for review November 6, 2024 15:02
@adambratschikaye adambratschikaye requested a review from a team as a code owner November 6, 2024 15:02
@adambratschikaye adambratschikaye requested review from fitzgen and bjorn3 and removed request for a team November 6, 2024 15:02
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I am not sure I understand what you are getting at with regards to windows, so we should resolve that before merging. Thanks!

@github-actions github-actions bot added the wasmtime:api Related to the API of the `wasmtime` crate itself label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants