Update memory configuration during fuzzing #9567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates how the `NormalMemoryConfig` works during fuzzing. Previously this was either 0 or an arbitrary 32-bit number. This ended up not not handling cases such as 4GiB exactly which is 1 larger than the 32-bit range. Additionally 33+-bit numbers were never tested. This intends to expand our fuzz coverage here by most of the time using the default settings of `Config` and then otherwise selecting amongst an "interesting" set of numbers such as 0, powers of two, etc.
fitzgen
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates how the
NormalMemoryConfigworks during fuzzing. Previously this was either 0 or an arbitrary 32-bit number. This ended up not not handling cases such as 4GiB exactly which is 1 larger than the 32-bit range. Additionally 33+-bit numbers were never tested. This intends to expand our fuzz coverage here by most of the time using the default settings ofConfigand then otherwise selecting amongst an "interesting" set of numbers such as 0, powers of two, etc.