Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some minor portability tweaks #9538

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Some minor portability tweaks #9538

merged 4 commits into from
Nov 1, 2024

Conversation

alexcrichton
Copy link
Member

Inspired during review of #9535

  • Platforms supporting vtune are now opt-in instead of being opt-out
  • Build all of the wasmtime CLI via cargo check for FreeBSD in CI (instead of just the wasmtime crate)
  • List illumos/freebsd as tier 3 in our tier listings

@alexcrichton
Change vtune platforms to be opt-in
636311b 
Previously integration with the `ittapi` crate and vtune profiling was
statically enabled for all platforms with an explicit list of platforms
that did not support it. Instead of requiring platforms to indicate they
don't support it (as it's an optional feature) this instead inverts
things to instead explicitly list platforms that do support it. The hope
is that this helps to make porting a bit easier where manual work is
only needed to get vtune running on a new platform.
@alexcrichton
Add illumos to tier listings
c17a829
@alexcrichton
Improve check we compile on FreeBSD
fd304b4 
The crate should compile by default (ideally) and it does now so assert
this in CI.
@alexcrichton
Clarify x86_64 freebsd is a tier 3 target
0581e05
@alexcrichton alexcrichton requested review from a team as code owners November 1, 2024 01:38
@alexcrichton alexcrichton requested review from fitzgen and removed request for a team November 1, 2024 01:38
@github-actions github-actions bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:docs Issues related to Wasmtime's documentation labels Nov 1, 2024
@alexcrichton alexcrichton added this pull request to the merge queue Nov 1, 2024
Merged via the queue into bytecodealliance:main with commit e3aab7d Nov 1, 2024
40 checks passed
@alexcrichton alexcrichton deleted the some-minor-updates branch November 1, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchickey pchickey pchickey approved these changes

@fitzgen fitzgen Awaiting requested review from fitzgen fitzgen is a code owner automatically assigned from bytecodealliance/wasmtime-core-reviewers

Assignees
No one assigned
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:docs Issues related to Wasmtime's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcrichton @pchickey