Fix custom-page-sizes + pooling-allocator + CoW #9533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a runtime error that happened with the pooling allocator when combined with the custom-page-sizes proposal. The bug that happened was that sizes flowing into the pooling allocator were no longer host-page-size-aligned which caused syscalls to return an error unexpectedly. This meant that situations which were supposed to work were in fact not working. The fix in this commit is to page-align incoming sizes into the CoW-pieces of memory management. This is coupled with a few more assertions that the `accessible` field is always page-aligned, as expected.
alexcrichton
force-pushed
the
fix-custom-page-sizes-and-pooling-and-cow
branch
from
d2e540f
to
173f5e9
Compare
github-actions
bot
added
the
wasmtime:api
Co-authored-by: Nick Fitzgerald <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Nov 3, 2024
This commit fixes a similar panic to one found in bytecodealliance#9533 where the pooling allocator was combined with modules using custom page sizes. The fix is similar where a variable needs page-aligning where previously it wasn't necessary due to wasm sizes always being page-aligned.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
This commit fixes a similar panic to one found in #9533 where the pooling allocator was combined with modules using custom page sizes. The fix is similar where a variable needs page-aligning where previously it wasn't necessary due to wasm sizes always being page-aligned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a runtime error that happened with the pooling allocator when combined with the custom-page-sizes proposal. The bug that happened was that sizes flowing into the pooling allocator were no longer host-page-size-aligned which caused syscalls to return an error unexpectedly. This meant that situations which were supposed to work were in fact not working.
The fix in this commit is to page-align incoming sizes into the CoW-pieces of memory management. This is coupled with a few more assertions that the
accessiblefield is always page-aligned, as expected.