Gate support for implicit return area pointers behind an option #9511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
requested review from
abrown and
elliottt
and removed request for
a team
It implements an incorrect ABI and may be removed in the future due to complexity reasons. By requiring to enable an option to use it, it becomes harder to accidentally hit the ABI issue and allows a more deprecation and eventual removal.
bjorn3
force-pushed
the
deny_implicit_sret_by_default
branch
from
83d8c13
to
5210a1d
Compare
cfallin
approved these changes
Oct 24, 2024
|
@bjorn3 it looks like a few riscv64 tests need the new option as well. Let me know when green and I'm happy to take a final look and merge! |
github-actions
bot
added
cranelift
|
CI is green. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
A few more failures in this run when it tried the full set on the merge queue, it looks like. (Feel free to use |
bjorn3
force-pushed
the
deny_implicit_sret_by_default
branch
from
9198a05
to
57ff00a
Compare
bjorn3
force-pushed
the
deny_implicit_sret_by_default
branch
from
57ff00a
to
5057651
Compare
|
Fixed those tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It implements an incorrect ABI and may be removed in the future due to complexity reasons. By requiring to enable an option to use it, it becomes harder to accidentally hit the ABI issue and allows a more deprecation and eventual removal.