-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs/stabilization of wasm proposals #9434
Update docs/stabilization of wasm proposals #9434
Conversation
This commit updates our documentation and documented status of various WebAssembly proposals. The goal of this commit it to explicitly list all requirements for each WebAssembly proposal in a way such that enabling a feature requires actively checking this table and performing effort to fill in. This is intended to mitigate GHSA-q8hx-mm92-4wvg where it was found that we were accidentally not fuzzing tail calls but had enabled it by default. This shuffles around some documentation, modernizes a bit, and notably tries to list out a green checkbox or red X for the status of various proposals. Notes for "holes" in the "on by default matrix" are also added.
Android is listed in Tier 3 now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
I wonder if there's a good place for documentation about determining when fuzzing is good enough. Perhaps something as simple as manually injecting todo!()
into new implementations so that running the fuzzer locally will panic when exercising the new behavior?
Label Messager: wasmtime:configIt looks like you are changing Wasmtime's configuration options. Make sure to
To modify this label's message, edit the To add new label messages or remove existing label messages, edit the |
We had a bunch of discussion today about this as well, but at least by my read there were no firm conclusions. I'm going to try to document better The One Location in fuzzing where proposals are enabled/disabled but beyond that while there was also discussion in the meeting about automatically probing coverage for fuzzers we didn't reach a firm conclusion about how best to do this. In the meantime I'm going to go ahead and merge this and I'll follow-up with more minor improvements too. |
Thanks for bringing this up in discussion (and these changes!). To further the discussions around testing our fuzzing, I filed #9449 just now. |
This commit updates our documentation and documented status of various WebAssembly proposals. The goal of this commit it to explicitly list all requirements for each WebAssembly proposal in a way such that enabling a feature requires actively checking this table and performing effort to fill in. This is intended to mitigate GHSA-q8hx-mm92-4wvg where it was found that we were accidentally not fuzzing tail calls but had enabled it by default.
This shuffles around some documentation, modernizes a bit, and notably tries to list out a green checkbox or red X for the status of various proposals. Notes for "holes" in the "on by default matrix" are also added.