Skip to content

Commit

Permalink
wasi-nn: update OpenVINO bindings (#9473)
Browse files Browse the repository at this point in the history
* wasi-nn: update OpenVINO bindings

Recent changes to OpenVINO's C bindings introduced breaking changes that
prevent use of older OpenVINO libraries with newer bindings (see
[openvino-rs#143] if you're interested in the details). This updates
both the bindings and the version of OpenVINO used to test against.

Fixes #9379.

[openvino-rs#143]: intel/openvino-rs#143

* vet: certify openvino version updates

All of these updates include code I've reviewed.

* ci: update `install-openvino-action`

prtest:full
  • Loading branch information
abrown authored Oct 16, 2024
1 parent 3f2febf commit 4ad393f
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,7 @@ jobs:
- uses: ./.github/actions/install-rust

# Install OpenVINO
- uses: abrown/install-openvino-action@v8
- uses: abrown/install-openvino-action@v9
if: runner.arch == 'X64'

# Install WinML for testing wasi-nn WinML backend. WinML is only available
Expand Down
15 changes: 7 additions & 8 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/wasi-nn/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ wasmtime = { workspace = true, features = [
# These dependencies are necessary for the wasi-nn implementation:
tracing = { workspace = true }
thiserror = { workspace = true }
openvino = { version = "0.7.2", features = [
openvino = { version = "0.8.0", features = [
"runtime-linking",
], optional = true }

Expand Down
18 changes: 18 additions & 0 deletions supply-chain/audits.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2274,6 +2274,12 @@ who = "Andrew Brown <[email protected]>"
criteria = "safe-to-deploy"
delta = "0.6.0 -> 0.7.2"

[[audits.openvino]]
who = "Andrew Brown <[email protected]>"
criteria = "safe-to-deploy"
delta = "0.7.2 -> 0.8.0"
notes = "No new unsafe functionality, just brings in openvino-sys changes and other minor improvements."

[[audits.openvino-finder]]
who = "Matthew Tamayo-Rios <[email protected]>"
criteria = "safe-to-deploy"
Expand All @@ -2297,6 +2303,12 @@ who = "Andrew Brown <[email protected]>"
criteria = "safe-to-deploy"
delta = "0.6.0 -> 0.7.2"

[[audits.openvino-finder]]
who = "Andrew Brown <[email protected]>"
criteria = "safe-to-deploy"
delta = "0.7.2 -> 0.8.0"
notes = "No logic changes in version bump."

[[audits.openvino-sys]]
who = "Matthew Tamayo-Rios <[email protected]>"
criteria = "safe-to-deploy"
Expand All @@ -2320,6 +2332,12 @@ who = "Andrew Brown <[email protected]>"
criteria = "safe-to-deploy"
delta = "0.6.0 -> 0.7.2"

[[audits.openvino-sys]]
who = "Andrew Brown <[email protected]>"
criteria = "safe-to-deploy"
delta = "0.7.2 -> 0.8.0"
notes = "This diff simply re-generates slightly newer C headers with a slightly newer version of bindgen."

[[audits.ort]]
who = "Andrew Brown <[email protected]>"
criteria = "safe-to-deploy"
Expand Down

0 comments on commit 4ad393f

Please sign in to comment.