Skip to content

Commit

Permalink
Disable fuzzing both custom-page-sizes and threads (#9524)
Browse files Browse the repository at this point in the history
This is an attempt to avoid #9523 in the fuzzers while that issue is
fixed independently. Fuzzing is pretty limited right now so the hope is
to let fuzzers find other issues while the refactoring here progresses.
  • Loading branch information
alexcrichton authored Oct 30, 2024
1 parent a2025f4 commit 3939172
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
6 changes: 6 additions & 0 deletions crates/fuzzing/src/generators/module.rs
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@ impl<'a> Arbitrary<'a> for ModuleConfig {
// do that most of the time.
config.disallow_traps = u.ratio(9, 10)?;

// FIXME(#9523) this `if` should ideally be deleted, requires some
// refactoring internally.
if config.custom_page_sizes_enabled && config.threads_enabled {
config.custom_page_sizes_enabled = false;
}

Ok(ModuleConfig { config })
}
}
Expand Down
4 changes: 3 additions & 1 deletion docs/stability-wasm-proposals.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,16 @@ column is below.
| [`function-references`] |||||||
| [`gc`] [^6] |||[^7] ||||
| [`wide-arithmetic`] |||||||
| [`custom-page-sizes`] ||| ||||
| [`custom-page-sizes`] ||| ⚠️[^8] ||||

[^6]: There is also a [tracking
issue](https://github.com/bytecodealliance/wasmtime/issues/5032) for the
GC proposal.
[^7]: The implementation of GC has [known performance
issues](https://github.com/bytecodealliance/wasmtime/issues/9351) which can
affect non-GC code when the GC proposal is enabled.
[^8]: Using custom-page-sizes is [known to have issues when combined with shared
memories](https://github.com/bytecodealliance/wasmtime/issues/9523).

## Unimplemented proposals

Expand Down

0 comments on commit 3939172

Please sign in to comment.