-
Notifications
You must be signed in to change notification settings - Fork 248
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't panic on duplicate imports when creating components (#1787)
Return an error instead since that's more appropriate in this context. Closes #1786
- Loading branch information
1 parent
8f247b9
commit fb403c3
Showing
3 changed files
with
19 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
;; FAIL: component new % | ||
|
||
(module | ||
(import "a" "a" (func)) | ||
(import "a" "a" (func)) | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
error: failed to encode a component from module | ||
|
||
Caused by: | ||
0: failed to decode world from module | ||
1: module was not valid | ||
2: module has duplicate import for `a::a` |