Stop moving Early FixedReg Use operands in certain conditions when Reuse operands are present. #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the reasons for the panic at here is that
Early FixedReg Uses
are having their position updated toLate
when there is already aLate FixedReg Def
or clobber of the fixedPReg
. This fixes that by not moving the operand's position if one of these already exist.It's still possible to cause this behavior if a
Late Def
operandReuse
s anEarly FixedReg Def
. However that is also easy to fix ifReuse
operands are checked to see if they reuse aFixedReg
operand.Thoughts? Am I missing something here? I ran the fuzzer overnight and compiled a few large binaries 200mb plus without fail; All run fine.